-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed python 3.3 dependency #58
Conversation
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
Comment on 8550e48. Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Removed' GitCommitBear, severity NORMAL, section |
8550e48
to
18a79df
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the newline here(at EOF) intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never; it is always bad on unix, except in a test file to show how bad it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emacs always adds a newline at the end of the file and always clears up trailing whitespaces. Is adding a newline at the end of the file is bad ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emacs is doing the right thing, assuming you are the author of that file.
It is distracting to add an EOL at EOF in a patch which isnt about that.
So, check your diff before you PR, and undo this emacs fixup unless you are modifying the last line of the file.
Ideally we create a bear to require it (coala/coala-bears#815), and then fix all the EOL problems at once. Until then, ignore any missing EOLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhisek- Or you could add another commit fixing just that (although I'm leaning towards a end-of-line bear too). The idea is that each commit should be about one thing and just that one thing. Makes it much easier later on when you go through your commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, this is merged lol
Guess we'll go with the bear thing now :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah..that was a mistake. I'll keep that in mind.
ack 18a79df |
@rultor merge |
Changed the file .ci/deps.sh so that it doesn't support python3.3
anymore as python3.3 hasn't been supported by coala for a long time.
see #35
Closes #57